ci(spell-check-diff): add explicit dict-packages #5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
xmfcx
force-pushed
the
ci/spell-check-dicts
branch
from
15f4ebd to
29fb8d5
Compare
mitsudome-r
approved these changes
Nov 28, 2024
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
|
https://github.com/streetsidesoftware/cspell-dicts/tree/main/dictionaries/en_US#note
Removed the default dictionaries. This PR is now overriding only |
youtalk
added a commit
to youtalk/autoware
that referenced
this pull request
Nov 29, 2024
* feat(docker): inherit `autoware-base` images (autowarefoundation#5492) * change run Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * use autoware-base images Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update health-check Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update load-env Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update load-env Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix rebase Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add build-args Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix hcl Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * chore(autoware.repos): fix `autoware.universe` and `autoware_launch` versions to `0.39.0` (autowarefoundation#5479) * ci: update the pr template and add comment-on-pr workflow (autowarefoundation#5500) Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> * ci(spell-check): switch the repository to autowarefoundation (autowarefoundation#5501) Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> * ci(pre-commit-ansible): autoupdate (autowarefoundation#5217) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> * ci(spell-check-diff): add explicit dict-packages (autowarefoundation#5503) Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> * refactor(docker): fix `Dockerfile` indent (autowarefoundation#5495) fix indent Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * feat(docker): update cleanup scripts (autowarefoundation#5497) * update cleanup scripts Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * revert to ubuntu-22.04 Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * ci(sync-files): make use of sync-files-templates repo (autowarefoundation#5504) Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Signed-off-by: M. Fatih Cırıt <mfc@autoware.org> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related section:
https://github.com/autowarefoundation/autoware-github-actions/blob/196ca1d50eef0fc7b898d85f7ccfe17b3c0e97b4/spell-check/action.yaml#L12-L17
These packages are being installed by https://github.com/autowarefoundation/autoware-github-actions/blob/196ca1d50eef0fc7b898d85f7ccfe17b3c0e97b4/spell-check/action.yaml#L32 as npm packages.
This PR adds the correct repository links.
How was this PR tested?
Notes for reviewers
None.
Effects on system behavior
None.